Align claims path query for ISO mdocs with JSON-based credentials #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
requested review from
GarethCOliver,
Sakurann,
TimoGlastra,
c2bo,
danielfett,
hlozi,
martijnharing and
tplooker
Sakurann
reviewed
May 21, 2025
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Contributor
Author
|
Please review again @GarethCOliver and @Sakurann. JSON and ISO mdocs should be now consistent and applied @GarethCOliver suggestions. Note that I also had to fix to allow negative integers for CBOR since labels in CBOR maps can be negative integers:
|
awoie
commented
May 27, 2025
jogu
requested changes
May 30, 2025
Co-authored-by: Joseph Heenan <joseph@authlete.com>
jogu
approved these changes
Jun 2, 2025
tplooker
approved these changes
Jun 8, 2025
GarethCOliver
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #468