require proof_signing_alg_values_supported to match key proof algorithms and rename ldp_vp to di_vp #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
requested review from
Sakurann,
TimoGlastra,
babisRoutis,
c2bo,
charsleysa,
jogu,
paulbastian,
selfissued and
tplooker
awoie
changed the title
Sakurann
approved these changes
Jun 3, 2025
tplooker
approved these changes
Jun 8, 2025
jogu
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does:
proof_signing_alg_values_supportedmust correspond toalgvalues in jwt/attestation/ldp proof types #499ldp_vpproof type todi_vpbecauseldpis dated terminology and falsely implies using the Linked Data Proof spec which is dated. Note that Data Integrity Proofs can be used to secure VCDM 1.x and VCDM 2.0 Verifiable Presentations.