Attempt to make OAuth2 security recommendations more actionable #534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daniel Fett pointed out that the current wording around the Best Current Practice for OAuth 2.0 Security document is misleading as VCI does not mention all the best current practices. Reword to try and address this. Add a recommendation to use FAPI2 as a way to comply with the BCP, and add some notes around where FAPI2 might not be applicable. Also replace the references to RFC9700 with BCP240 as it is likely to be an evolving document. closes #291
tplooker
approved these changes
Jun 8, 2025
Contributor
tplooker
left a comment
tplooker
left a comment
There was a problem hiding this comment.
LGTM, good improvement to just reference the BCP here more generally.
Sakurann
approved these changes
Jun 11, 2025
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
lgtm.
just curious - it is best practice to reference as bcp240 and not as rfc9700 even if these are technically the same thing?
Sakurann
requested review from
GarethCOliver,
awoie,
bc-pi,
c2bo,
hlozi,
martijnharing and
paulbastian
Contributor
Author
Referencing rfc9700 kinda sets the expectation as "implement exactly what's in this RFC" whereas referencing BCP240 is a more explicit "follow OAuth security BCPs even if they're been updated since rfc9700". |
charsleysa
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Daniel Fett pointed out that the current wording around the Best Current Practice for OAuth 2.0 Security document is misleading as VCI does not mention all the best current practices.
Reword to try and address this.
Add a recommendation to use FAPI2 as a way to comply with the BCP, and add some notes around where FAPI2 might not be applicable.
Also replace the references to RFC9700 with BCP240 as it is likely to be an evolving document.
closes #291