Clarify meaning of absence of some credential metadata #552
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charsleysa
reviewed
Jun 19, 2025
Make some items required when key bound credentials are in use, so the wallets knows if it has to supply proofs or not, and if so in what format. closes #530
Make some items required when key bound credentials are in use, so the wallets knows if it has to supply proofs or not, and if so in what format. closes #530
jogu
force-pushed
the
missing-metadata-meaning
branch
from
f25a63b to
edcadb9
Compare
charsleysa
approved these changes
Jun 19, 2025
tplooker
approved these changes
Jun 20, 2025
c2bo
approved these changes
Jun 21, 2025
davidz25
approved these changes
Jun 23, 2025
Sakurann
reviewed
Jun 23, 2025
Sakurann
reviewed
Jun 23, 2025
Sakurann
reviewed
Jun 23, 2025
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
i think some of the current wording is a bit awkward - made suggestions
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Sakurann
reviewed
Jun 24, 2025
Sakurann
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make some items required when key bound credentials are in use, so the wallets knows if it has to supply proofs or not, and if so in what format.
closes #530