Additional examples for credential issuer metadata #584
Conversation
c2bo
requested review from
GarethCOliver,
Sakurann,
TimoGlastra,
awoie,
jogu and
ubamrein
jogu
left a comment
jogu
left a comment
There was a problem hiding this comment.
I ran it against the schema check we have in the conformance suite and it didn't complain, although it's not currently setup to flag unexpected entries so things could've slipped through.
| "authorization_servers": [ | ||
| "https://server.example.com" | ||
| ], | ||
| "credential_endpoint": "https://credential-issuer.example.com", |
There was a problem hiding this comment.
Should probably have a path? e.g. "/credential" (same problem exists in the signed version too)
…D4VCI into 576-signed-metadata-example
ubamrein
left a comment
ubamrein
left a comment
There was a problem hiding this comment.
I did not look closely at the claims, but checked signature and x509-cert, which both look good to me :)
|
Can we get a few more reviews from people with implementations checking for the serialization (and maybe also already signed issuer metadata)? |
|
Discussed on this morning's WG call; @charsleysa to review and then we'll merge. |
charsleysa
left a comment
charsleysa
left a comment
There was a problem hiding this comment.
Approved, with a couple of nitpick suggestions
Co-authored-by: Stefan Charsley <charsleysa@gmail.com>
Closes #576, Closes #563
Could someone please verify that these examples are properly constructed / parsing?