align holder binding terminology to VP #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogu
reviewed
Aug 13, 2025
c2bo
requested changes
Aug 13, 2025
Member
c2bo
left a comment
c2bo
left a comment
There was a problem hiding this comment.
Not sure the change from Verifiable Credential to Credential helps if we only make that change here. We should either make that change in a lot more places or revert the change here imho
paulbastian
requested changes
Aug 13, 2025
Contributor
paulbastian
left a comment
paulbastian
left a comment
There was a problem hiding this comment.
I would rather leave it here as is, making a note in the terminology what the equivalent term in OpenID4VP is and fix VP terminology in 1.1
Sakurann
commented
Aug 26, 2025
Sakurann
commented
Aug 26, 2025
Sakurann
commented
Aug 26, 2025
Comment on lines
104
to
108
| Claims-based Holder Binding: | ||
| : Ability of the Holder to prove legitimate possession of a Credential by proving certain claims, e.g., name and date of birth, for example by presenting another Credential. Claims-based Holder Binding allows long-term, cross-device use of a Credential as it does not depend on cryptographic key material stored on a certain device. One example of such a Credential could be a diploma. | ||
|
|
||
| Biometrics-based Binding: | ||
| : Ability of the Holder to prove legitimate possession of a Verifiable Credential by demonstrating a certain biometric trait, such as fingerprint or face. One example of a Verifiable Credential with Biometrics-based Holder Binding is a mobile driving license [@ISO.18013-5], which contains a portrait of the holder. | ||
| Biometrics-based Holder Binding: | ||
| : Ability of the Holder to prove legitimate possession of a Credential by demonstrating a certain biometric trait, such as a fingerprint or face. One example of a Credential with biometric Holder Binding is a mobile driving license [@ISO.18013-5], which contains a portrait of the Holder. |
Collaborator
Author
There was a problem hiding this comment.
because openid4vp literally defines
Verifiable Credential (VC): An Issuer-signed Credential whose authenticity can be cryptographically verified.
i am not comfortable reverting these to verifiable credential
Co-authored-by: Christian Bormann <chris.bormann@gmx.de>
Sakurann
commented
Aug 26, 2025
c2bo
approved these changes
Aug 26, 2025
jogu
requested changes
Aug 26, 2025
Co-authored-by: Joseph Heenan <joseph@authlete.com>
jogu
reviewed
Aug 27, 2025
|
|
||
| Biometrics-based Binding: | ||
| : Ability of the Holder to prove legitimate possession of a Verifiable Credential by demonstrating a certain biometric trait, such as fingerprint or face. One example of a Verifiable Credential with Biometrics-based Holder Binding is a mobile driving license [@ISO.18013-5], which contains a portrait of the holder. | ||
| Biometrics-based Holder Binding: |
Contributor
There was a problem hiding this comment.
This term isn't actually used in the specification so we could consider removing the definition?
|
|
||
| Claims-based Binding: | ||
| : Ability of the Holder to prove legitimate possession of a Verifiable Credential by proofing certain claims, e.g., name and date of birth, for example, by presenting another Verifiable Credential. Claims-based Holder Binding allows long-term, cross-device use of a Credential as it does not depend on cryptographic key material stored on a certain device. One example of such a Verifiable Credential could be a Diploma. | ||
| Claims-based Holder Binding: |
Contributor
There was a problem hiding this comment.
I'm okay with this change, but shouldn't we update the use of "Claims-based Binding" in the rest of the doc to say "Claims-based Holder Binding" too?
Sakurann
commented
Aug 28, 2025
Co-authored-by: Christian Bormann <chris.bormann@gmx.de>
jogu
approved these changes
Aug 29, 2025
paulbastian
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.