fix: just do derived origin binding #629
Closed
+181
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… relate to the VP not the credentials to be issued
…ry, not the credential being issued
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
4 tasks
jogu
added a commit
that referenced
this pull request
Oct 25, 2025
Is it clear enough that Credential Formats correspond to the requested Credential in the IAR, and not to the requested Credential in the VCI request? I did not update the audience in the VP, but propose a fix in £629 al here fix: just do derived origin binding #629 fixes #590 fixes #620 (changes by Oliver, moved from the 1.0 to 1.1 spec by Joseph)
jogu
force-pushed
the
awoie/fix-590-iar
branch
from
0ee5a46 to
08b7bc8
Compare
jogu
added a commit
that referenced
this pull request
Oct 25, 2025
Is it clear enough that Credential Formats correspond to the requested Credential in the IAR, and not to the requested Credential in the VCI request? I did not update the audience in the VP, but propose a fix in £629 al here fix: just do derived origin binding #629 fixes #590 fixes #620 (changes by Oliver, moved from the 1.0 to 1.1 spec by Joseph)
jogu
force-pushed
the
awoie/fix-590-iar
branch
from
08b7bc8 to
11451b5
Compare
Collaborator
|
WG discussion. Close this PR, open a new one once there is agreement on the direction of derived origin binding. Most likely we need to work on origin terminology throughout the spec. there is an issue #620 to discuss that |
Contributor
Author
|
Closing since we have a separate issue for the underlying potential issue #620 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the change to do derived origin binding instead of full URL endpoint binding for audience/session transcript/domain.