-
Notifications
You must be signed in to change notification settings - Fork 37
add identifiers for issuing credential of the same type, different content #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
e17e53e
add identifiers for credential of the same type, different content
9b19b7f
add authorization details token response
96d410f
Apply suggestions from code review
Sakurann 07cef0a
Apply suggestions from Dr.'s code review
Sakurann 3619d1f
draft of how to obtain parts of the credential issuer metadata (very …
081d36a
identifiers and authorization_details_identifiers can appear in the s…
Sakurann c461479
revert parts that were out of scope of this PR
c384ac8
Merge branch 'same-type-diff-id' of https://github.com/openid/OpenID4…
43dc1ad
identifiers and format parameters in the credential response are mutu…
Sakurann 11bae18
Merge branch 'same-type-diff-id' of https://github.com/openid/OpenID4…
5b8bfbe
change parameter names to c_identifier
af7f963
revert undecided parts
bd876d7
clarify the definition of c_identifiers and make it the only option t…
a30f96a
readd top-level c_identifiers in token response
1e68d31
Apply suggestions from Giuseppe's code review
Sakurann ebb3eea
Merge branch 'main' of https://github.com/openid/OpenID4VCI into same…
b269cc0
remove an option to use c_identifier in token response with scopes
08bceb9
rename to c_instance_identifier
8709747
c_instance_identifiers_supported metadata parameter added
1590a1a
reverting the change that is out of scope of this PR
f9cb5be
Apply description suggestion from giuseppe's code review
Sakurann e7df0a8
Apply suggestions from Gisueppe's code review
Sakurann 898d10b
Merge branch 'main' of https://github.com/openid/OpenID4VCI into same…
c2eef28
expand description of credential instance
c173216
fix example to make format and identifier parameters mutually exclusive
88761be
adding "MUST not be used otherwise"
Sakurann 5eff07e
remove JSON in JSON string and array definitions
Sakurann 9b594a7
rename parameter name to credential_identifier
10ce7b1
fixing remaining JSON string mentions
7f90b00
add changelog
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.