make authorization_servers credential issuer metadata parameter an array
#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
awoie,
bc-pi,
danielfett,
selfissued and
tlodderstedt
jogu
requested changes
Sep 29, 2023
peppelinux
requested changes
Oct 4, 2023
peppelinux
requested changes
Oct 26, 2023
c2bo
requested changes
Oct 27, 2023
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it> Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
peppelinux
requested changes
Oct 27, 2023
peppelinux
reviewed
Oct 28, 2023
peppelinux
reviewed
Oct 28, 2023
peppelinux
reviewed
Oct 28, 2023
selfissued
reviewed
Oct 31, 2023
Names of sets or lists of things should be plural.
selfissued
approved these changes
Oct 31, 2023
c2bo
approved these changes
Oct 31, 2023
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
peppelinux
approved these changes
Nov 1, 2023
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
Sakurann
commented
Nov 2, 2023
bc-pi
approved these changes
Nov 2, 2023
Collaborator
Author
|
agreed to merge following @pmhsfelix 's review |
pmhsfelix
approved these changes
Nov 2, 2023
Contributor
pmhsfelix
left a comment
pmhsfelix
left a comment
There was a problem hiding this comment.
Approved with just one comment.
Sakurann
commented
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem statement, and various options that have been considered are explained in Issue #72.
There are use-cases when Credential Issuer is using different authorization servers depending on the grant type (for example, using existing AS for authz code grant and a new one for pre-auth because was not able to make changes to an existing AS in production.) Inspired by a newly adopted resource metadata draft in oauth wg https://datatracker.ietf.org/doc/html/draft-ietf-oauth-resource-metadata-00#section-2-2.4.
When discussed at oauth security workshop 2023, there have been no concerns with the approach, given that credential issuer needs how to differentiate from which AS each access token is coming from.