Clarify that alg_values_supported is optional #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jogu
approved these changes
Mar 1, 2024
c2bo
approved these changes
Mar 5, 2024
Sakurann
reviewed
Mar 6, 2024
Sakurann
approved these changes
Mar 6, 2024
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
one nit, but rationale makes sense
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #16.
This pull request clarifies that
alg_values_supportedis optional. In certain cases, for example, if there is no prior knowledge of wallet metadata,alg_values_supportedcan be omitted. In such cases, without prior knowledge, the verifier cannot make any assumptions about the cryptographic suites supported by the wallet. The wallet may or may not support specific cryptographic suites.