Update the text about the response returned by the browser API #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with the latest position from the WICG group, in particular as shown here: https://github.com/WICG/digital-credentials/pull/141/files i.e. the VP response is inside the 'data' member within the response object. Also fix where presentation_submission was shown as a string in one example and add an example for an encrypted response for completeness. closes #201
c2bo
reviewed
Jul 15, 2024
peppelinux
reviewed
Jul 15, 2024
Sakurann
reviewed
Jul 15, 2024
Sakurann
approved these changes
Jul 15, 2024
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
c2bo
approved these changes
Jul 17, 2024
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
marcoscaceres
approved these changes
Jul 18, 2024
Contributor
marcoscaceres
left a comment
marcoscaceres
left a comment
There was a problem hiding this comment.
Just added the }s as suggestions, as no doubt people will by copy/pasting this.
Add closing } to examples as per Marcos's suggestion Co-authored-by: Marcos Cáceres <marcos@marcosc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it consistent with the latest position from the WICG group, in particular as shown here:
https://github.com/WICG/digital-credentials/pull/141/files
i.e. the VP response is inside the 'data' member within the response object.
Also fix where presentation_submission was shown as a string in one example and add an example for an encrypted response for completeness.
closes #201