Enable non-breaking extensibility #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfissued
requested review from
Sakurann,
awoie,
bc-pi,
jogu,
peppelinux,
rohe and
tplooker
bc-pi
reviewed
Aug 31, 2024
peppelinux
reviewed
Sep 4, 2024
|
|
||
| Additional Authorization Request parameters MAY be defined and used, | ||
| as described in [@!RFC6749]. | ||
| The Wallet MUST ignore any unrecognized parameters. |
Member
There was a problem hiding this comment.
yes, this is also linked to this: https://github.com/openid/OpenID4VP/pull/233/files#r1744570536
peppelinux
reviewed
Sep 4, 2024
peppelinux
reviewed
Sep 4, 2024
peppelinux
reviewed
Sep 4, 2024
peppelinux
reviewed
Sep 4, 2024
peppelinux
approved these changes
Sep 4, 2024
Member
peppelinux
left a comment
peppelinux
left a comment
There was a problem hiding this comment.
I approve this in advance since my comments are merely editorial and easy to be addressed asap
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Co-authored-by: Giuseppe De Marco <giuseppe.demarco@teamdigitale.governo.it>
Sakurann
reviewed
Sep 11, 2024
Sakurann
reviewed
Sep 11, 2024
Sakurann
reviewed
Sep 11, 2024
Sakurann
reviewed
Sep 11, 2024
Sakurann
reviewed
Sep 11, 2024
Sakurann
reviewed
Sep 11, 2024
Sakurann
reviewed
Sep 11, 2024
Sakurann
requested changes
Sep 11, 2024
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
would love to see some tweaks
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Member
Author
|
Tweaked |
awoie
approved these changes
Sep 12, 2024
Collaborator
|
Open for over 2 weeks, all comments addressed & mentioned on multiple WG calls and 3 approvals - merging! Thanks Mike! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227