add session transcript for browser api #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awoie
changed the title
awoie
requested review from
Sakurann,
jogu,
leecam,
martijnharing and
paulbastian
timcappalli
reviewed
Dec 19, 2024
timcappalli
reviewed
Dec 19, 2024
timcappalli
reviewed
Dec 19, 2024
timcappalli
reviewed
Dec 19, 2024
Sakurann
reviewed
Dec 19, 2024
timcappalli
reviewed
Dec 19, 2024
Sakurann
reviewed
Dec 19, 2024
Co-authored-by: Tim Cappalli <tim@cappalli.me>
Co-authored-by: Tim Cappalli <tim@cappalli.me>
Co-authored-by: Tim Cappalli <tim@cappalli.me>
Co-authored-by: Tim Cappalli <tim@cappalli.me>
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
timcappalli
reviewed
Jan 7, 2025
timcappalli
approved these changes
Jan 7, 2025
Co-authored-by: Tim Cappalli <tim@cappalli.me>
c2bo
approved these changes
Jan 7, 2025
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
timcappalli
approved these changes
Jan 9, 2025
c2bo
approved these changes
Jan 9, 2025
leecam
approved these changes
Jan 9, 2025
tlodderstedt
added
the
ISO_VirtualMeeting
tlodderstedt
requested changes
Jan 10, 2025
Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
tlodderstedt
approved these changes
Jan 10, 2025
Sakurann
approved these changes
Jan 14, 2025
Collaborator
Sakurann
left a comment
Sakurann
left a comment
There was a problem hiding this comment.
some editorial comments that would like to see addressed, but from technical perspective looks good
|
|
||
| * `DeviceEngagementBytes` MUST be `null`. | ||
| * `EReaderKeyBytes` MUST be `null`. | ||
| * `Handover` MUST be the `OID4VPDCAPIHandover` CBOR structure as defined below. |
Collaborator
There was a problem hiding this comment.
OpenID4VPDCAPIHandover is probably sufficient.
Not sure why anyone would confuse CBOR structure names with OIDs?
I am 100% with you Oliver, but this has came up enough times, unfortunately.......
Sakurann
reviewed
Jan 14, 2025
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
c2bo
reviewed
Jan 14, 2025
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
selfissued
requested changes
Jan 14, 2025
Member
selfissued
left a comment
selfissued
left a comment
There was a problem hiding this comment.
Please change mdoc-oid4vp to mdoc-openid4vp.
Collaborator
|
Discussion in the WG Call on the 14th of Jan: this PR is good to be merged (after changing "OID4VPDCAPIHandover" to "OpenID4VPDCAPIHandover"). |
Contributor
Author
Good catch. I updated the PR to implement @c2bo @selfissued and @tlodderstedt comments. |
selfissued
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a general definition for session transcript and handover for browser api.
Partially fixes openid/OpenID4VC-HAIP#135
Out of scope: