-
Notifications
You must be signed in to change notification settings - Fork 37
Improvements regarding DC API #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
This text is intended to say "Other OAuth parameters must not be used unless they have explicitly been described somewhere as being suitable to use over the DC API." (along with the standard "If you get something you don't understand, ignore it.")
Yes, correct. |
…id/OpenID4VP into awoie/fix-453
…ear the client id is not issued by the wallet
…onsistent with the rest of the main part of the spec
tlodderstedt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested small changes
Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
|
i think this also fixes #541 by separating security considerations section? |
martijnharing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the proposed change is merged (see comment), I can approve.
done |
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
Co-authored-by: Tim Cappalli <tim@cappalli.me>
This PR makes editorial improvements on DC API. Also made the text more consistent with DCQL.
Fixes #453
Fixes #437
Fixes #528
Fixes #541