Remove PE as a query language #479

danielfett · 2025-03-28T12:03:56Z

This PR does the following:

Remove Presentation Exchange as a query language incl. the auth request parameters presentation_definition and presentation_definition_uri
~~Introduce the DCQL feature contains to enable matching W3C VC types, which so far was not possible with DCQL~~ - reverted, see discussion
Update the DCQL rules and extra parameters for W3C VCs and AnonCreds to ensure that useful queries can be made
Update all relevant examples

Fixes #211

merging this unblocks PR on #6

Copilot

Copilot reviewed 5 out of 25 changed files in this pull request and generated no comments.

Files not reviewed (20)

examples/request/dcql_ac_vc_sd.json: Language not supported
examples/request/dcql_jwt_vc.json: Language not supported
examples/request/dcql_ldp_vc.json: Language not supported
examples/request/pd_ac_vc.json: Language not supported
examples/request/pd_ac_vc_sd.json: Language not supported
examples/request/pd_jwt_vc.json: Language not supported
examples/request/pd_ldp_vc.json: Language not supported
examples/request/pd_sd_jwt_vc.json: Language not supported
examples/request/request_object_client_id_did.json: Language not supported
examples/request/vp_token_alternative_credentials.json: Language not supported
examples/request/vp_token_type_and_claims.json: Language not supported
examples/request/vp_token_type_only.json: Language not supported
examples/response/jarm_jwt_enc_only_vc_json_body.json: Language not supported
examples/response/jarm_jwt_vc_json_body.json: Language not supported
examples/response/presentation_submission.json: Language not supported
examples/response/presentation_submission_multiple_vps.json: Language not supported
examples/response/ps_ac_vc_sd.json: Language not supported
examples/response/ps_jwt_vc.json: Language not supported
examples/response/ps_ldp_vc.json: Language not supported
examples/response/ps_sd_jwt_vc.json: Language not supported

leecam

Might be better to split out the support for contains in a separate PR. But looks good to me either way

openid-4-verifiable-presentations-1_0.md

Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>

openid-4-verifiable-presentations-1_0.md

Sakurann · 2025-03-31T17:06:24Z

openid-4-verifiable-presentations-1_0.md

-`invalid_presentation_definition_uri`:
-
- The Presentation Definition URL cannot be reached.
-
-`invalid_presentation_definition_reference`:
-
- The Presentation Definition URL can be reached, but the specified `presentation_definition` cannot be found at the URL.
-


I support it, and we never defined dcql_query_uri parameter but I think it's worth noting that with this PR, we are losing the ability to pass query language by reference

That ability doesn't work with DC API anyway so I'm not sure it's a big loss.

openid-4-verifiable-presentations-1_0.md

Sakurann · 2025-03-31T17:14:53Z

openid-4-verifiable-presentations-1_0.md

-<{{examples/response/token_response_vp_token_sd_jwt_vc.txt}}
-
-In this example the `vp_token` contains only the disclosures for the claims specified in the `presentation_submission`, along with a Key Binding JWT.
+The `transaction_data_hashes` response parameter defined in (#transaction_data), if Transaction Data is used, MUST be included in the Key Binding JWT as a top level claim. This means that transaction data mechanism cannot be used with SD-JWT VCs without cryptographic key binding (i.e., which do not use the KB-JWT).


this will probably conflict with #421. tho #421 probably getting merged first. @sander

openid-4-verifiable-presentations-1_0.md

Co-authored-by: Andres Olave <sloops77@users.noreply.github.com>

TimoGlastra

This PR looks good to me, especially the removal of the Presentation Exchange part.

I see some missing gaps related to DCQL querying and the Verifier Metadata which were highlighted because of the changes in this PR, for which I've opened #495 and #494 (I'm happy to a PR for both of those issues).

examples/request/dcql_jwt_vc.json

examples/request/dcql_ldp_vc.json

openid-4-verifiable-presentations-1_0.md

c2bo

Not sure about that one sentence to validate vp_token - everything else looks good to me

openid-4-verifiable-presentations-1_0.md

jogu · 2025-04-03T15:08:51Z

openid-4-verifiable-presentations-1_0.md

-`invalid_presentation_definition_uri`:
-
- The Presentation Definition URL cannot be reached.
-
-`invalid_presentation_definition_reference`:
-
- The Presentation Definition URL can be reached, but the specified `presentation_definition` cannot be found at the URL.
-


That ability doesn't work with DC API anyway so I'm not sure it's a big loss.

openid-4-verifiable-presentations-1_0.md

Co-authored-by: Timo Glastra <timo@animo.id>

Co-authored-by: Joseph Heenan <joseph@authlete.com>

openid-4-verifiable-presentations-1_0.md

bc-pi · 2025-04-04T14:00:53Z

openid-4-verifiable-presentations-1_0.md

+
+* `proof_type_values`: OPTIONAL. A JSON array containing types of proofs that
+  the Verifier accepts to be used in the Verifiable Presentation, for example
+  `["RsaSignature2018"]`.


'18 was a good vintage for RSA

bc-pi

swooping in at the 11th hour with some trivial nitpicking suggestions but overall approve

(done with permission of Daniel, who checked them but isn't currently somewhere where he could easily apply them) Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>

jogu · 2025-04-04T18:11:19Z

Merging as per agreement on yesterday's WG call and noting that there have been no objections to Kristina explicitly asking on the mailing list if anyone had any concerns ( https://lists.openid.net/pipermail/openid-specs-digital-credentials-protocols/Week-of-Mon-20250331/000707.html )

danielfett added 4 commits March 28, 2025 13:03

Exchanging presentation exchange

28ffead

typo

940839f

Merge branch 'main' into danielfett/remove-pe

2308a91

Fix examples on various formats

77fc192

danielfett marked this pull request as ready for review March 28, 2025 12:59

danielfett requested review from c2bo, Copilot and jogu March 28, 2025 12:59

Copilot AI reviewed Mar 28, 2025

View reviewed changes

danielfett requested a review from Sakurann March 28, 2025 13:00

Wording on scopes

829508f

leecam approved these changes Mar 28, 2025

View reviewed changes

c2bo added 2 commits March 29, 2025 12:50

fix rendering

74e18fb

remove pe from redirect_uri example

76dc58a

selfissued approved these changes Mar 29, 2025

View reviewed changes

c2bo added 2 commits March 29, 2025 18:08

fix more remnants of presentation definition

bc0b25c

change example to valid credential_ids (dcql id rules)

089c558

c2bo reviewed Mar 31, 2025

View reviewed changes

Apply suggestions from Christian's review

a5b8567

Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

Sakurann reviewed Mar 31, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

danielfett and others added 3 commits April 3, 2025 08:50

Merge branch 'main' into danielfett/remove-pe

bddcf50

Review feedback

35ec2fb

Update openid-4-verifiable-presentations-1_0.md

661cbcc

Co-authored-by: Andres Olave <sloops77@users.noreply.github.com>

This was referenced Apr 3, 2025

Support did as trusted authorities for DCQL #494

Open

add verifier_attestations parameter to authz req #482

Merged

Update the Verifier Metadata definition for W3C credentials and mDOC #495

Closed

TimoGlastra approved these changes Apr 3, 2025

View reviewed changes

c2bo approved these changes Apr 3, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

TimoGlastra mentioned this pull request Apr 3, 2025

Scvenema/455/clarify alg values supported parameter #488

Closed

jogu approved these changes Apr 3, 2025

View reviewed changes

Daniel Fett and others added 10 commits April 4, 2025 09:09

Change back to match on values in AC

2422328

Apply suggestions from Timo's review

f31b271

Co-authored-by: Timo Glastra <timo@animo.id>

Merge branch 'main' into danielfett/remove-pe

76fe2ec

Fix version in reference to previous draft

e2c8e8e

Fix validation rules

1763dde

No claims path pointers into presentations

9686abd

Update openid-4-verifiable-presentations-1_0.md

c4d326f

Co-authored-by: Joseph Heenan <joseph@authlete.com>

Update openid-4-verifiable-presentations-1_0.md

3126d88

Co-authored-by: Joseph Heenan <joseph@authlete.com>

More feedback on PR incorporated

e7d6b90

typo

1b912b9

bc-pi reviewed Apr 4, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

bc-pi reviewed Apr 4, 2025

View reviewed changes

openid-4-verifiable-presentations-1_0.md Outdated Show resolved Hide resolved

bc-pi reviewed Apr 4, 2025

View reviewed changes

TimoGlastra mentioned this pull request Apr 4, 2025

revamp vp formats #500

Merged

bc-pi approved these changes Apr 4, 2025

View reviewed changes

Apply Brian's suggestions

c8bfc0c

(done with permission of Daniel, who checked them but isn't currently somewhere where he could easily apply them) Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>

jogu merged commit d2edbe6 into main Apr 4, 2025
2 checks passed

jogu mentioned this pull request Apr 4, 2025

The description of 3.1 and 3.2 almost makes readers think that Presentation Definition has to be used #502

Closed

jogu mentioned this pull request May 1, 2025

presentation_definition may be provided in the RP's metadata #407

Closed

Remove PE as a query language #479

Remove PE as a query language #479

Uh oh!

Conversation

danielfett commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

leecam left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sakurann Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

jogu Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sakurann Mar 31, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TimoGlastra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

c2bo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jogu Apr 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bc-pi Apr 4, 2025

Choose a reason for hiding this comment

Uh oh!

bc-pi left a comment

Choose a reason for hiding this comment

Uh oh!

jogu commented Apr 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

danielfett commented Mar 28, 2025 •

edited

Loading