Skip to content

Conversation

@martijnharing
Copy link
Contributor

@martijnharing martijnharing commented Mar 31, 2025

closes #413

@danielfett
Copy link
Contributor

if we merge #479, the new parameter types_values for W3C VCs needs to be updated to be MANDATORY as well.

@Sakurann Sakurann added this to the Final 1.0 milestone Apr 2, 2025
martijnharing and others added 2 commits April 3, 2025 12:20
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
@danielfett
Copy link
Contributor

@martijnharing please make the new type_values for W3C credentials mandatory as well and @c2bo can probably tell us which of schema_id_values and cred_def_id_values we should make mandatory as well

@c2bo
Copy link
Member

c2bo commented Apr 5, 2025

@martijnharing please make the new type_values for W3C credentials mandatory as well and @c2bo can probably tell us which of schema_id_values and cred_def_id_values we should make mandatory as well

I'd say at least one of schema_id_values or cred_def_id_values MUST be present. In theory it would be schema ID and did or cred_def_id as far as I understand the current AnonCreds iteration @TimoGlastra?

@TimoGlastra
Copy link
Member

Yes we basically use did + schema id to query, as this doesn't limit key rotation through the credential definition.

I think that at least one of them needs to be defined makes sense. Not sure if it's an AND or an OR, but it's never really needed to include both.

@danielfett
Copy link
Contributor

In that case, requiring one of them to be present seems reasonable. @martijnharing

@Sakurann
Copy link
Collaborator

Sakurann commented Apr 7, 2025

WG discussion
for AnonCreds, one of the schema_id_values or cred_def_id_values must be present.
for W3C, type_values must be present

@Sakurann Sakurann merged commit 375047f into main Apr 11, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optionality of mdoc specific DCQL fields

7 participants