-
Notifications
You must be signed in to change notification settings - Fork 37
add verifier_attestations parameter to authz req #482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please add a change log :) |
done :) |
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Co-authored-by: Joseph Heenan <joseph@heenan.me.uk>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
Co-authored-by: Timo Glastra <timo@animo.id>
I think the best approach would be to follow the JWT approach where the |
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
c2bo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about the proof of possession part tbh
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
Signed-off-by: Mirko Mollik <mirko.mollik@eudi.sprind.org>
change type to format Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
c2bo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really happy with wallets having to parse everything first (to discover type) before understanding if it's relevant, but overall this variant seems to achieve the requirements
| This specification supports two models for proof of possession: | ||
|
|
||
| - **claim-bound attestations**: The attestation is not signed by the Relying Party, but bound to it. The exact binding mechanism is defined by the type of the definition. For example for JWTs, the `sub` claim is including the distinguished name of the Certificate that was used to sign the request. The binding may also include the client_id parameter. | ||
| - **key-bound attestations**: The attestation's proof of possession is signed by the Relying Party with a key contained or related to the attestation . To bind the signature to the presentation request, the respective signature object should include the `nonce` and `client_id` request parameters. The attestation and the proof of possession have to be passed in the attachment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **key-bound attestations**: The attestation's proof of possession is signed by the Relying Party with a key contained or related to the attestation . To bind the signature to the presentation request, the respective signature object should include the `nonce` and `client_id` request parameters. The attestation and the proof of possession have to be passed in the attachment. | |
| - **key-bound attestations**: The attestation's proof of possession is signed by the Verifier with a key contained or related to the attestation. To bind the signature to the presentation request, the respective object signed by the Verifier should include the `nonce` and `client_id` request parameters. The attestation and the proof of possession have to be passed in the attachment. |
Me neither, but since it's only parsing and not validating, it should be fine. If there occur attestations where it becomes more complex, we can add an optional attribute that can be used as an identifier. But at this point we were not able to find a good solution that pleased everyone. |
|
|
||
| This specification supports two models for proof of possession: | ||
|
|
||
| - **claim-bound attestations**: The attestation is not signed by the Relying Party, but bound to it. The exact binding mechanism is defined by the type of the definition. For example for JWTs, the `sub` claim is including the distinguished name of the Certificate that was used to sign the request. The binding may also include the client_id parameter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - **claim-bound attestations**: The attestation is not signed by the Relying Party, but bound to it. The exact binding mechanism is defined by the type of the definition. For example for JWTs, the `sub` claim is including the distinguished name of the Certificate that was used to sign the request. The binding may also include the client_id parameter. | |
| - **claim-bound attestations**: The attestation is not signed by the Verifier, but bound to it. The exact binding mechanism is defined by the type of the definition. For example for JWTs, the `sub` claim is including the distinguished name of the Certificate that was used to sign the request. The binding may also include the client_id parameter. |
Closes #396