-
Notifications
You must be signed in to change notification settings - Fork 37
Clarify key selection for client_metadata jwks #483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Honestly not sure this works well with anticipated changes from #477 |
| ### Key Selection for `jwks` Client Metadata Parameter {#client_metadata_key_selection} | ||
| JWK sets SHOULD NOT contain multiple keys with the same `kid`. However, when there are multiple keys with the same `kid`, the verifier shall consider other JWK attributes, such as `kty`, `use`, `alg`, etc., when selecting the verification key for the particular JWS message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| ### Key Selection for `jwks` Client Metadata Parameter {#client_metadata_key_selection} | |
| JWK sets SHOULD NOT contain multiple keys with the same `kid`. However, when there are multiple keys with the same `kid`, the verifier shall consider other JWK attributes, such as `kty`, `use`, `alg`, etc., when selecting the verification key for the particular JWS message. | |
| ### Key Selection for `jwks` Client Metadata Parameter {#client_metadata_key_selection} | |
| JWK sets SHOULD NOT contain multiple keys with the same `kid`. However, when there are multiple keys with the same `kid`, the verifier shall consider other JWK attributes, such as `kty`, `use`, `alg`, etc., when selecting the verification key for the particular JWS message. |
I think I was largly reacting to the text (now gone) that was borrowed from FAPI. But the "selecting the verification key for the particular JWS message" in this PR is in a new little section that is refrenced only from the context of the client_metadata/jwks param where it says "Public keys included in this parameter MUST NOT be used to verify the signature of signed Authorization Requests". Admittedly I don't know specifically what that feedback from the implementers was but the text introduced here is incorrect so probably doesn't meaningfully address it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see prior comments #483 (comment) & #483 (comment)
|
superseded by #477 |
PR Checkpoints
Summary
Clarify key selection for client_metadata jwks like described in FAPI: https://openid.net/specs/openid-financial-api-part-2-1_0.html#duplicate-key-identifiers
Related Issue(s)
resolves #438
Special notes for your reviewer