Allow presentation without holder binding #513
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sakurann
requested review from
GarethCOliver,
Sakurann,
awoie,
babisRoutis,
bc-pi,
c2bo,
davidz25,
hlozi,
jogu,
martijnharing,
paulbastian,
tlodderstedt and
tplooker
TimoGlastra
reviewed
Apr 9, 2025
| The Credential format identifiers are `jwt_vc_json` to request a W3C Verifiable Credential and `jwt_vp_json` to request a W3C Verifiable Presentation. | ||
| The Credential Format Identifiers are `jwt_vc_json` to request a W3C Verifiable Credential and `jwt_vp_json` to request a Verifiable Presentation compliant to the [@VC_DATA] specification. | ||
|
|
||
| If `jwt_vc_json` is used, the Credential is returned without Holder Binding. Therefore, the Verifier MUST set the `allow_replay` parameter in the Credential Query to `true` if it is using `jwt_vc_json`. Otherwise, `allow_replay` MUST be `false`. Wallets MUST reject requests that do not follow these rules. |
Member
There was a problem hiding this comment.
I feel like allow_replay is more of a result of not requiring key binding. But I don't think it's the best name for a query parameter.
I'm not sure if there's an overarching term. I think in OID4VCI it's called key binding (so something like 'require_key_binding) or more generic that a presentation is required (so require_verifiable_presentation`).
Contributor
Author
There was a problem hiding this comment.
I don't think require_key_binding sounds serious enough :-) I'd prefer a wording that conveys that this is a critial parameter.
tlodderstedt
requested changes
Apr 10, 2025
| replayed. (#preventing-replay) contains additional considerations for this case. | ||
|
|
||
| To request a Credential without proof of Holder Binding, the Verifier specifies a | ||
| different format in the DCQL request as defined in (#dcql_query) and |
Collaborator
There was a problem hiding this comment.
would it make sense to add an example?
| The Credential format identifiers are `jwt_vc_json` to request a W3C Verifiable Credential and `jwt_vp_json` to request a W3C Verifiable Presentation. | ||
| The Credential Format Identifiers are `jwt_vc_json` to request a W3C Verifiable Credential and `jwt_vp_json` to request a Verifiable Presentation compliant to the [@VC_DATA] specification. | ||
|
|
||
| If `jwt_vc_json` is used, the Credential is returned without Holder Binding. Therefore, the Verifier MUST set the `allow_replay` parameter in the Credential Query to `true` if it is using `jwt_vc_json`. Otherwise, `allow_replay` MUST be `false`. Wallets MUST reject requests that do not follow these rules. |
Co-authored-by: Torsten Lodderstedt <torsten@lodderstedt.net>
paulbastian
requested changes
Apr 11, 2025
Co-authored-by: Paul Bastian <paul.bastian@posteo.de>
Merged
paulbastian
reviewed
Apr 11, 2025
Sakurann
reviewed
Apr 11, 2025
paulbastian
approved these changes
Apr 11, 2025
Co-authored-by: Paul Bastian <paul.bastian@posteo.de>
tlodderstedt
approved these changes
Apr 11, 2025
Sakurann
approved these changes
Apr 11, 2025
c2bo
approved these changes
Apr 11, 2025
jogu
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
Executive summary:
state: now REQUIRED if at least one Presentation without Holder Binding is requested.Alternative: "if only pres. without holder binding are requested", but the current rule seems easier to implement considering that credentials can be returned conditionally etc.
allow_replaythat requests a Presentation without Holder Bindingjwt_vp_json,jwt_vc_json,ldp_vp,ldp_vc— I therefore introduced the rule that *vc must be used if and only if allow_replay is true.Alternative 1: Remove the *vp formats, but that would be another breaking change, I suppose? Alternative 2: Remove the *vc formats, but that would mean requesting a "*vp" when in reality, only a credential is returned.
Let the bikeshedding on the parameter name begin, other ideas I had were
insecure_no_bindingand simplykey_binding: false. I thinkallow_replaycaptures the risk quite well and to the point, without sounding too scare, and doesn't sound too nice for developers to "just give it a try".