add identifier for JWS JSON Serialized multi RP requests #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
GarethCOliver,
bc-pi,
hlozi,
jogu,
leecam,
marcoscaceres,
martijnharing,
timcappalli and
tlodderstedt
bc-pi
reviewed
Apr 8, 2025
bc-pi
requested changes
Apr 8, 2025
Member
bc-pi
left a comment
bc-pi
left a comment
There was a problem hiding this comment.
unsigned requests are not using JWS compact serialization so that needs to be changed. I'm not sure "JWS Compact Serialized signed requests" is gonna be better than just "Signed requests" but don't care deeply either way there.
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
Collaborator
Author
|
I am trying to match the description with the section titles introduced in #308 PR so slight preference towards |
bc-pi
approved these changes
Apr 9, 2025
timcappalli
approved these changes
Apr 9, 2025
c2bo
approved these changes
Apr 11, 2025
paulbastian
reviewed
Apr 11, 2025
Co-authored-by: Paul Bastian <paul.bastian@posteo.de>
paulbastian
approved these changes
Apr 11, 2025
jogu
approved these changes
Apr 11, 2025
GarethCOliver
approved these changes
Apr 11, 2025
leecam
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #515