Specifies value matching for mdocs via a reference to cbor-to-json #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarethCOliver
requested review from
Sakurann,
danielfett,
davidz25 and
martijnharing
davidz25
approved these changes
Apr 12, 2025
Contributor
davidz25
left a comment
davidz25
left a comment
There was a problem hiding this comment.
LGTM, much cleaner than my PR - thanks Gareth!
charsleysa
approved these changes
Apr 12, 2025
charsleysa
reviewed
Apr 12, 2025
Co-authored-by: Stefan Charsley <charsleysa@gmail.com>
c2bo
approved these changes
Apr 12, 2025
Sakurann
reviewed
Apr 13, 2025
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Sakurann
approved these changes
Apr 14, 2025
jogu
reviewed
Apr 15, 2025
martijnharing
approved these changes
Apr 15, 2025
tplooker
approved these changes
Apr 15, 2025
Collaborator
|
wg discussion: ok to merge once @jogu re-reviews |
jogu
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #481 as discussed in the working group call.
Resolves #535