Remove references to 18013-7 from OpenId4VP #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the references to 18013-7, per WG discussion as it is not compatible with the current document. resolves #519
Collaborator
|
makes me think if we should also remove references to 23220-4..? |
Contributor
Author
The remaining 23220-4 are just to it as the 'building blocks' version of 18013-5. I think this still makes sense (it's only the remote presentation part that is in conflict). |
Sakurann
approved these changes
Apr 14, 2025
jogu
approved these changes
Apr 15, 2025
awoie
approved these changes
Apr 15, 2025
Contributor
awoie
left a comment
awoie
left a comment
There was a problem hiding this comment.
LGTM, SessionTranscript for vanilla OID4VP could be done in 1.1.
Collaborator
|
because some people asked.. i think what this PR means is..
|
Collaborator
|
wg discussion: ok to merge once @martijnharing forms an opinion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the references to 18013-7, per WG discussion as it is not compatible with the current document.
resolves #519
This approach to be brought up with WG10 this week.
We could specify a session transcript in Invocation via other methods {#non-dc-api-invocation} to resolve #402
as follows:
OpenID4VPVanillaHandover = [
"OpenID4VPVanillaHandover", ; A fixed identifier for this handover type
OpenID4VPVanillaHandoverInfoHash ; A cryptographic hash of OpenID4VPVanillaHandoverInfo
]
; Contains the sha-256 hash of OpenID4VPVanillaHandoverInfoBytes
OpenID4VPVanillaHandoverInfoHash = bstr
; Contains the bytes of OpenID4VPVanillaHandoverInfo encoded as CBOR
OpenID4VPVanillaHandoverInfoBytes = bstr .cbor OpenID4VPVanillaHandoverInfo
OpenID4VPDCAPIHandoverInfo = [
clientId,
responseUri,
nonce,
jwk_thumbprint
] ; Array containing handover parameters
(nonce/jwk_thumbprint as in DC API, clientId/responseUri from request).
This would ~match what is done today for 18013-7, while being inline with what we do in the DC API. However I think it leaves some questions (how do we handle multi-rp auth, do we really need clientId and responseUri) so would rather re-introduce in a follow-up PR, or in 1.1.