Skip to content

Conversation

@jogu
Copy link
Collaborator

@jogu jogu commented Apr 16, 2025

We can potentially look at aligning with a "values_supported" style approach that aligns with https://openid.net/specs/openid-connect-rp-metadata-choices-1_0.html in the future.

closes #552

We can potentially look at aligning with a "values_supported" style
approach that aligns with https://openid.net/specs/openid-connect-rp-metadata-choices-1_0.html
in the future.

closes #552
Copy link
Member

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Joseph

Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@bc-pi
Copy link
Member

bc-pi commented Apr 22, 2025

I believe this would be a mistake that moves things in the wrong direction for the wrong reasons that will not be easy to undo or move away from. See also #552 (comment). But I honestly don't think I have the energy to engage on this.

@tplooker
Copy link
Contributor

Note - Disregard the prior approvals and comments on this PR, the scope of it has changed based on the WG discussion had on the 23rd of April, see changes from @Sakurann's commit for the new scope of change for this PR.

@tplooker tplooker changed the title Revert to JARM style use of authorization_encrypted_response_alg Rename authorization_encrypted_response_enc parameter Apr 22, 2025
@Sakurann Sakurann requested a review from selfissued April 22, 2025 20:06
Copy link
Member

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply my suggestions. Then I should be able to approve.

Co-authored-by: Michael B. Jones <michael_b_jones@hotmail.com>
Co-authored-by: Brian Campbell <71398439+bc-pi@users.noreply.github.com>
Copy link
Member

@c2bo c2bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing that I wondered about: If the Verifier provides multiple keys and the algorithm doesn't uniquely identify the selected key, then the Verifier should include a kid in the JWKs.

Seems somewhat obvious and unrealistic tbh and we mandate kid to be in the JWE if present in the JWK, so should be fine as is?

@Sakurann Sakurann added this to the Final 1.0 milestone Apr 24, 2025
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
@Sakurann Sakurann merged commit f2ea811 into main Apr 24, 2025
2 checks passed
@Sakurann
Copy link
Collaborator

  • changelog needs to be moved to -28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Treatment of encrypted responses inconsistent with JARM while reusing JARM parameter

8 participants