Error responses for DC API #556
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sakurann
requested review from
hlozi,
marcoscaceres,
martijnharing and
samuelgoto
c2bo
reviewed
Apr 17, 2025
tlodderstedt
approved these changes
Apr 17, 2025
Collaborator
There was a problem hiding this comment.
added proposal for example and realized @c2bo was quicker ;-)
Collaborator
|
WG discussion:
|
hlozi
approved these changes
Apr 18, 2025
Sakurann
reviewed
Apr 21, 2025
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
GarethCOliver
approved these changes
Apr 21, 2025
Contributor
GarethCOliver
left a comment
GarethCOliver
left a comment
There was a problem hiding this comment.
Added the privacy consideration section (please read/review)
tplooker
reviewed
Apr 21, 2025
timcappalli
commented
Apr 21, 2025
timcappalli
commented
Apr 21, 2025
timcappalli
commented
Apr 21, 2025
timcappalli
commented
Apr 21, 2025
Co-authored-by: Tobias Looker <tplooker@gmail.com>
Co-authored-by: Tim Cappalli <tim@cappalli.me>
Co-authored-by: Tim Cappalli <tim@cappalli.me>
c2bo
reviewed
Apr 22, 2025
Sakurann
reviewed
Apr 22, 2025
Co-authored-by: Kristina <52878547+Sakurann@users.noreply.github.com>
Collaborator
|
WG discussion:
|
Co-authored-by: Christian Bormann <8774236+c2bo@users.noreply.github.com>
Sakurann
approved these changes
Apr 23, 2025
c2bo
approved these changes
Apr 23, 2025
martijnharing
requested changes
Apr 23, 2025
Collaborator
|
issue will be opened to follow up on the error code. |
Co-authored-by: Martijn Haring <62745275+martijnharing@users.noreply.github.com>
martijnharing
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #204
Probably needs some word smithing but adds some text Appendix A around the format of the error response and a note that protocol errors will still result in a fulfilled promise at the DC API layer.
@GarethCOliver feel free to just push to this same branch / PR with the privacy considerations.