Remove reference to CBOR-encoding the JWK thumbprint in OpenID4VPDCAPIHandoverInfo
#592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2bo
approved these changes
May 6, 2025
awoie
approved these changes
May 7, 2025
paulbastian
approved these changes
May 8, 2025
mickrau
approved these changes
May 8, 2025
MasterKale
added a commit
to MasterKale/SimpleDigiCreds
that referenced
this pull request
May 8, 2025
It was an OID4VP spec text issue, see openid/OpenID4VP#592
Contributor
Author
|
I'm working to get myself added to our Contribution Agreement, I apologize for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a mention of CBOR-encoding the bytes of a JWK thumbprint to bring the spec text in line with the non-normative example of how to compose
OpenID4VPDCAPIHandoverInfo. As discussed in #591, the CDDL doesn't seem to mention thatjwk_thumbprintis CBOR-encoded, so it's likely this simple removal of the word "CBOR" is enough to bring the spec text in line with the examples and CDDL definition.Fixes #591.