Skip to content

Conversation

@Oltho
Copy link
Contributor

@Oltho Oltho commented Dec 15, 2024

Description

Creating the json-schema 2020-12 schema for the access evaluation request and access evaluation response from the schema define at Authzen - Authorization API 1.1 - draft 01

Related issue

Additional note

  1. We should consider some kind of testing to ensure that schema are compliant, as of today I'm manually validating via https://www.jsonschemavalidator.net/ and some basic example
    a. ensure minimum schema
    b. ensure the additional properties are allowed when allowed

  2. The field $id should be replace with a more permanent id (eg: IANA registration ?)

  3. We can reuse the schema to create an valid OAS 3.1 specs

  4. We should provide guidance to people to generate "language specifics model" from json-schema or provide "authzen" own model via known platform (eg: maven)

@netlify
Copy link

netlify bot commented Dec 15, 2024

👷 Deploy request for authzen-todo pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3bd3725

@ogazitt
Copy link
Collaborator

ogazitt commented Dec 17, 2024

Good work!

@ogazitt
Copy link
Collaborator

ogazitt commented Dec 18, 2024

@Oltho we need to ensure that you've signed an IPR agreement before we can merge this PR. Please feel free to reach out if you have one on file already.

@jogu
Copy link

jogu commented Dec 19, 2024

We should consider some kind of testing to ensure that schema are compliant, as of today I'm manually validating via https://www.jsonschemavalidator.net/ and some basic example

https://github.com/openid/OpenID4VP?tab=readme-ov-file#running-tests and https://bitbucket.org/openid/ekyc-ida/src/master/ have tests that can check the examples in the spec comply with the schema, might be useful to consider using. It would be externalising the examples as they're currently inline in the spec.

@Oltho
Copy link
Contributor Author

Oltho commented Dec 23, 2024

@Oltho we need to ensure that you've signed an IPR agreement before we can merge this PR. Please feel free to reach out if you have one on file already.

completed, please let me know if additional information is required

@ogazitt ogazitt merged commit 096b5a9 into openid:main Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants