Policy operators: more permissive restrictions when combining add and superset_of #111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfissued
requested review from
peppelinux,
rohe,
selfissued,
vdzhuvinov and
ve7jtb
Member
|
This was discussed on the 9-Oct-24 Federation editors' call. @vdzhuvinov intends to look into how this interacts with the defined order of applying policy operators. |
zachmann
force-pushed
the
policy_operators_combining_add_and_superset
branch
from
4dd0e8d to
05ca1ed
Compare
zachmann
changed the title
selfissued
approved these changes
Oct 30, 2024
Member
|
This is incorporated into #177 . We will close this shortly unless reasons to keep it open are identified. |
Member
|
Closing since this is replaced by #177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #11 I'd argue that the
addandsuperset_ofpolicy operators can be combined nevertheless of their value.addis applied first, thensuperset_ofchecks if the value is a superset.