-
Notifications
You must be signed in to change notification settings - Fork 14
Describe Client Authentication with Automatic Registration #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Giuseppe De Marco <demarcog83@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially I thought this was sufficient, but Tim's comment ( #147 (comment) ) has caused me to re-consider.
https://github.com/openid/rp-metadata-choices doesn't define multi-values-capable entries for revocation_endpoint_auth_methods_supported or introspection_endpoint_auth_methods_supported. I think we need to either:
- Define these, or:
- Make clear that the token endpoint auth methods is used for all endpoints
|
@jogu, does openid/rp-metadata-choices#7 do the trick so that you can approve this PR? |
|
https://github.com/openid/rp-metadata-choices doesn't define multi-valued-capable client metadata for "this is how i can authenticate at the introspection/revocation/par endpoint" because these would have no single-valued counterpart since clients do in-fact use the same client authentication method for all authenticated endpoints and refer back to the original authenticated endpoint - the token endpoint, ergo The inclusion of
|
|
It would be interesting to know if the OIDC test suite allows a client to use different client authentication methods at different endpoints. The OIDC standard allows it and therefor the test suite should be able to support it. |
Same but it shouldn't be a mystery that it was a mistake.
I recall this conversation similarly.
Absolutely not.
Agree that 2 is right. |
|
I will update the PR to apply choice 2 above. |
The test suite doesn't allow for it, and I don't believe the OIDC standard allows it at the endpoints that are in scope for / tested by the test suite. (I'm not sure I understand how the question is relevant to the issue described in #147.) |
|
@jogu, in light of openid/rp-metadata-choices#8 and the clarification to use |
Fixes #147