Old issues

[dickhardt]

dickhardt/openid-provider-commands#12

@aaronpk does this capture the meaning better?

[aaronpk]

It looks like this PR also has the commit from #14 in it. I assume that's not intentional. It's not a huge deal here because it's just one commit, but it will become difficult to pick apart the diffs for larger commits in the future.

[aaronpk]

I'm a bit confused about how the description of the Unauthorize command is split between two sections, I feel like that is not helping the clarity of what is expected here.

There's the "Unauthorize Functionality" section which says

The RP MUST revoke all active sessions and MUST reverse all authorization that may have been granted to applications, including offline_access, for Account resources identified by the sub.

That's pretty clear. But then there's the "Unauthorize Command" section which says

The OP sends this Command when it wants the RP to undo the last OpenID Connect login.

which is where the confusion is happening. It would probably be better to remove any description of the outcome from the command section, leaving the outcomes to be only described in the "Unauthorize Functionality" section.

[dickhardt]

It looks like this PR also has the commit from #14 in it. I assume that's not intentional. It's not a huge deal here because it's just one commit, but it will become difficult to pick apart the diffs for larger commits in the future.

That was not intentional -- indicator of my lack of GitHub skills

[dickhardt]

which is where the confusion is happening. It would probably be better to remove any description of the outcome from the command section, leaving the outcomes to be only described in the "Unauthorize Functionality" section.

I agree that would be more crisp. Will adjust.