add client_id claim and make aud the command_endpoint #4 #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adeinega
reviewed
Apr 29, 2025
| - **aud** | ||
| REQUIRED. | ||
| Audience(s), as specified in Section 2 of {{OpenID.Core}}. | ||
| The Command Endpoint. |
Member
There was a problem hiding this comment.
What's about "URL of the RP's Command Endpoint", or a bit shorter "the RP's Command Endpoint"?
This URL should be the sole audience of this claim, OpenID Connect Core allows to specify multiple audiences, as an array, and that leaves some room for misuse.
Collaborator
Author
There was a problem hiding this comment.
Command Endpoint is a defined term earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supported per
https://lists.openid.net/pipermail/openid-specs-ab/2025-April/010762.html