Skip to content

Commit 28d7796

Browse files
authored
Consolidating changes from multiple PRs (#117)
* Consolidating changes from PRs Consolidating changes from PRs 1. #109 2. #108 3. #100 * Shayne's suggestion Shayne's suggestion * More places to fix MUST -> SHOULD More places to fix MUST -> SHOULD
1 parent a2fe379 commit 28d7796

File tree

1 file changed

+19
-9
lines changed

1 file changed

+19
-9
lines changed

openid-sharedsignals-framework-1_0.md

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,12 @@ contributor:
6161
contribution: |
6262
Steve defined the format field of Complex Subjects
6363
64+
-
65+
ins: A. Deshpande
66+
name: Apoorva Deshpande
67+
org: Okta
68+
email: apoorva.deshpande@okta.com
69+
6470
normative:
6571
CLIENTCRED:
6672
author:
@@ -787,9 +793,9 @@ following properties:
787793

788794
stream_id
789795

790-
> **Transmitter-Supplied**, A string that uniquely identifies the stream. Stream
791-
IDs MUST be unique per Reciever. This value is generated by the Transmitter
792-
when the stream is created.
796+
> **Transmitter-Supplied**, A string that uniquely identifies the stream. A
797+
transmitter MUST generate a unique ID for each of its non-deleted streams
798+
at the time of stream creation.
793799

794800
iss
795801

@@ -818,13 +824,15 @@ events_requested
818824
> **Receiver-Supplied**, An array of URIs identifying the set of events that
819825
the Receiver requested. A Receiver SHOULD request only the events that it
820826
understands and it can act on. This is configurable by the Receiver. A
821-
Transmitter MUST ignore any array values that it does not understand.
827+
Transmitter MUST ignore any array values that it does not understand. This
828+
array SHOULD NOT be empty.
822829

823830
events_delivered
824831

825-
> **Transmitter-Supplied**, An array of URIs which is the intersection of
826-
"events_supported" and "events_requested". These events MAY be delivered over
827-
the Event Stream. A Receiver MUST rely on the values received in this field
832+
> **Transmitter-Supplied**, An array of URIs identifying the set of events that
833+
the Transmitter MUST include in the stream. This is a subset (not necessarily
834+
a proper subset) of the intersection of "events_supported" and
835+
"events_requested". A Receiver MUST rely on the values received in this field
828836
to understand which event types it can expect from the Transmitter.
829837

830838
delivery
@@ -1160,7 +1168,8 @@ configuration in the body.
11601168
The stream_id property MUST be present in the request. Other properties
11611169
MAY be present in the request. Any Receiver-Supplied property present in the
11621170
request MUST be updated by the Transmitter. Any properties missing in the
1163-
request MUST NOT be changed by the Transmitter.
1171+
request MUST NOT be changed by the Transmitter. If `events_requested` property is
1172+
included in the request, it SHOULD NOT be an empty array.
11641173

11651174
Transmitter-Supplied properties beside the stream_id MAY be present,
11661175
but they MUST match the expected value. Missing Transmitter-Supplied
@@ -1246,7 +1255,8 @@ The stream_id and the full set of Receiver-Supplied properties MUST be present
12461255
in the PUT body, not only the ones that are specifically intended to be changed.
12471256
Missing Receiver-Supplied properties MUST be interpreted as requested to be
12481257
deleted. Event Receivers MAY read the configuration first, modify the JSON
1249-
{{RFC7159}} representation, then make a replacement request.
1258+
{{RFC7159}} representation, then make a replacement request. If `events_requested`
1259+
property is included in the request, it SHOULD NOT be an empty array.
12501260

12511261
Transmitter-Supplied properties besides the stream_id MAY be present,
12521262
but they MUST match the expected value. Missing Transmitter-Supplied

0 commit comments

Comments
 (0)