Skip to content

Commit 9497085

Browse files
committed
incorporates Atul and Shane's feedback
1 parent 311bf8e commit 9497085

File tree

3 files changed

+23
-19
lines changed

3 files changed

+23
-19
lines changed

openid-sharedsignals-framework-1_0.html

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
html5lib 1.1
4545
intervaltree 3.1.0
4646
Jinja2 3.1.2
47-
lxml 4.9.2
47+
lxml 4.5.2
4848
MarkupSafe 2.1.2
4949
pycountry 22.3.5
5050
PyYAML 5.3.1
@@ -2351,9 +2351,11 @@ <h5 id="name-creating-a-stream">
23512351
an HTTP POST request to the Configuration Endpoint. On receiving a valid request
23522352
the Event Transmitter responds with a "201 Created" response containing a
23532353
<span><a href="#RFC7159" class="internal xref">JSON</a> [<a href="#RFC7159" class="cite xref">RFC7159</a>]</span> representation of the stream's configuration in the body.<a href="#section-7.1.1.1-1" class="pilcrow"></a></p>
2354-
<p id="section-7.1.1.1-2">If the stream already exists, the Event Transmitter responds with HTTP status code
2355-
"200 OK" and includes a <span><a href="#RFC7159" class="internal xref">JSON</a> [<a href="#RFC7159" class="cite xref">RFC7159</a>]</span> representation of the stream's configuration
2356-
in the body.<a href="#section-7.1.1.1-2" class="pilcrow"></a></p>
2354+
<p id="section-7.1.1.1-2">If a stream already exists, and the Transmitter allows multiple streams with the
2355+
same Receiver, the Event Transmitter MUST respond with a new stream ID. If the
2356+
Transmitter does not allow multiple streams with the same Receiver, it MUST respond
2357+
respond with HTTP status code "200 OK" and include a <span><a href="#RFC7159" class="internal xref">JSON</a> [<a href="#RFC7159" class="cite xref">RFC7159</a>]</span> representation
2358+
of the existing stream's configuration in the body.<a href="#section-7.1.1.1-2" class="pilcrow"></a></p>
23572359
<p id="section-7.1.1.1-3">The HTTP POST request MAY contain the Receiver-Supplied values of the Stream
23582360
Configuration (<a href="#stream-config" class="auto internal xref">Section 7.1.1</a>) object:<a href="#section-7.1.1.1-3" class="pilcrow"></a></p>
23592361
<p id="section-7.1.1.1-4">events_requested<a href="#section-7.1.1.1-4" class="pilcrow"></a></p>

openid-sharedsignals-framework-1_0.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -829,9 +829,11 @@ an HTTP POST request to the Configuration Endpoint. On receiving a valid request
829829
the Event Transmitter responds with a "201 Created" response containing a
830830
[JSON][RFC7159] representation of the stream’s configuration in the body.
831831

832-
If the stream already exists, the Event Transmitter responds with HTTP status code
833-
"200 OK" and includes a [JSON][RFC7159] representation of the stream’s configuration
834-
in the body.
832+
If a stream already exists, and the Transmitter allows multiple streams with the
833+
same Receiver, the Event Transmitter MUST respond with a new stream ID. If the
834+
Transmitter does not allow multiple streams with the same Receiver, it MUST respond
835+
respond with HTTP status code "200 OK" and include a [JSON][RFC7159] representation
836+
of the existing stream’s configuration in the body.
835837

836838
The HTTP POST request MAY contain the Receiver-Supplied values of the Stream
837839
Configuration ({{stream-config}}) object:

openid-sharedsignals-framework-1_0.txt

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -916,9 +916,12 @@ Tulshibagwale, et al. Standards Track [Page 16]
916916
responds with a "201 Created" response containing a JSON [RFC7159]
917917
representation of the stream's configuration in the body.
918918

919-
If the stream already exists, the Event Transmitter responds with
920-
HTTP status code "200 OK" and includes a JSON [RFC7159]
921-
representation of the stream's configuration in the body.
919+
If a stream already exists, and the Transmitter allows multiple
920+
streams with the same Receiver, the Event Transmitter MUST respond
921+
with a new stream ID. If the Transmitter does not allow multiple
922+
streams with the same Receiver, it MUST respond respond with HTTP
923+
status code "200 OK" and include a JSON [RFC7159] representation of
924+
the existing stream's configuration in the body.
922925

923926
The HTTP POST request MAY contain the Receiver-Supplied values of the
924927
Stream Configuration (Section 7.1.1) object:
@@ -940,10 +943,7 @@ Tulshibagwale, et al. Standards Track [Page 16]
940943

941944
format
942945

943-
*Receiver-Supplied*, The Subject Identifier Format that the
944-
Receiver wants for the events. If not set then the Transmitter
945-
might decide to use a type that discloses more information than
946-
necessary.
946+
947947

948948

949949

@@ -954,6 +954,11 @@ Tulshibagwale, et al. Standards Track [Page 17]
954954
SharedSignals February 2023
955955

956956

957+
*Receiver-Supplied*, The Subject Identifier Format that the
958+
Receiver wants for the events. If not set then the Transmitter
959+
might decide to use a type that discloses more information than
960+
necessary.
961+
957962
The following is a non-normative example request to create an Event
958963
Stream:
959964

@@ -994,11 +999,6 @@ Tulshibagwale, et al. Standards Track [Page 17]
994999

9951000

9961001

997-
998-
999-
1000-
1001-
10021002

10031003

10041004

0 commit comments

Comments
 (0)