Stream ID must be unique per stream #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stream ID to be unique per stream
FragLegs
approved these changes
Aug 30, 2023
Contributor
FragLegs
left a comment
FragLegs
left a comment
There was a problem hiding this comment.
This is more clear. Thanks!
Uniqueness per Transmitter
tulshi
previously approved these changes
Sep 5, 2023
tulshi
reviewed
Sep 5, 2023
|
|
||
| > **Transmitter-Supplied**, A string that uniquely identifies the stream. Stream | ||
| IDs MUST be unique per Reciever. This value is generated by the Transmitter | ||
| IDs MUST be unique per stream in the context of each transmitter. This value is generated by the Transmitter |
Contributor
There was a problem hiding this comment.
"across all streams that are currently open in a Transmitter"
Contributor
Author
There was a problem hiding this comment.
Maybe the following to handle "future" streams, rather than just the "currently open"
Transmitter-Supplied, A string that uniquely identifies the stream. A transmitter MUST generate a unique ID for each of it's streams.
Verbiage change
tulshi
reviewed
Sep 6, 2023
| > **Transmitter-Supplied**, A string that uniquely identifies the stream. Stream | ||
| IDs MUST be unique per Reciever. This value is generated by the Transmitter | ||
| when the stream is created. | ||
| > **Transmitter-Supplied**, A string that uniquely identifies the stream. A transmitter MUST generate a unique ID for each of it's streams at the time of stream creation. |
Contributor
There was a problem hiding this comment.
it's streams -> its open streams (no apostrophe, and specify open, since the rest of the sentence talks about the time of creation)
Contributor
Author
|
Following up on #117 |
tulshi
pushed a commit
that referenced
this pull request
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the transmitter does not have any notion of the receiver uniqueness, it makes more sense to callout the stream ID to be unique per stream.
In the update stream event,
audis expected as a stream ID which is expected unique per stream as well.