Fixes #221 - Add event_metadata to CAEP and RISC #244
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appsdesh
requested changes
Apr 1, 2025
Contributor
appsdesh
left a comment
appsdesh
left a comment
There was a problem hiding this comment.
- what does it mean by action?
- how would we prevent bloating?
- Why are we singling this out "This claim SHOULD not be used to express information about
the subject." needs more concrete guidance
Contributor
Author
|
FragLegs
reviewed
Apr 1, 2025
Contributor
|
"action" here is needed, but we do not need to call it out in the description. In the event_metadata field it is setting the foundation to expand upon profile events that might be mandatory via a contract between the transmitter and receiver. We need guidelines for this and a use case with event_metadata details.
|
appsdesh
approved these changes
Apr 2, 2025
Contributor
appsdesh
left a comment
appsdesh
left a comment
There was a problem hiding this comment.
New changes look good. Suggesting a nit to remove redundant event from the key
| occurred. Its value is a JSON number representing the number of seconds | ||
| from 1970-01-01T0:0:0Z as measured in UTC until the date/time. | ||
|
|
||
| event_metadata |
Contributor
There was a problem hiding this comment.
Suggested change
| event_metadata | |
| metadata |
| <t>The following claims are optional unless otherwise specified in the event type definition. | ||
|
|
||
| <list style="symbols"> | ||
| <t>event_metadata - optional, JSON object,metadata specific to the event provided by the |
Contributor
There was a problem hiding this comment.
Suggested change
| <t>event_metadata - optional, JSON object,metadata specific to the event provided by the | |
| <t>metadata - optional, JSON object,metadata specific to the event provided by the |
tulshi
added
the
v1Final
Contributor
Author
|
@iamseanodentity do you can an example of this you can supply? |
Contributor
I will get to this tonight. Would you like me to add inline or just here and you can handle the copy? |
Contributor
Author
|
decided against this 4/15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added event_metadata to CAEP and RISC for the transmitter to provide additional information about the event itself.
Fixes #221