Clarify Stream Creation default delivery method behavior #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I believe that @atultulshi said we should not include this in the next release because it is a backwards-incompatible change: #149 |
FragLegs
reviewed
Apr 1, 2025
jischr
commented
Apr 1, 2025
iamseanodentity
approved these changes
Apr 1, 2025
Contributor
iamseanodentity
left a comment
iamseanodentity
left a comment
There was a problem hiding this comment.
as discussed on the call today.
FragLegs
approved these changes
Apr 1, 2025
Contributor
|
For anyone reading the comments - we adjusted the language so that it is fully backwards compatible and just gives a suggestion for how to respond if the Tx does not support polling. |
appsdesh
pushed a commit
to appsdesh/sharedsignals
that referenced
this pull request
Apr 2, 2025
A follow up from openid#247
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149
This PR should be non-normative (is it?!) i've tried to better describe the default behavior when a transmitter does not support the defaulted stream delivery method.