Skip to content

Conversation

@tulshi
Copy link
Contributor

@tulshi tulshi commented Jan 19, 2023

Please review TXT and HTML output manually, since the source files are new (and in a new format). A few known issues:

  • The 4th level headings do not appear in TOC
  • Many links do not have the corresponding visible text clickable
  • Specs other than the new files have not been updated to reflect the change
  • The link to the CAEP spec is still a TODO in the SSF spec

Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor capitalization stuff. I only commented on the MD source.

Of particular concern is the possibility that SETs are confused for other kinds
of JWTs. The Security Considerations section of {{RFC8417}} has several sub-sections
on this subject. The SSE Framework is asking for further restrictions:
on this subject. The SSF Framework is asking for further restrictions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/SSF/Shared Signals
-or-
d/Framework

specified in the Discovery {{discovery}} section.

# Example SETs that conform to the SSE framework {#events-examples}
# Example SETs that conform to the Shared Signals framework {#events-examples}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/framework/Framework

Discovery Section 6 section.

5. Example SETs that conform to the SSE framework
5. Example SETs that conform to the Shared Signals framework
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/framework/Framework


The following are hypothetical examples of SETs that conform to the
SSE framework.
Shared Signals framework.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/framework/Framework

@tulshi tulshi closed this May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants