Skip to content

Conversation

@timcappalli
Copy link
Member

Issue #46: add stream exists behavior

@timcappalli timcappalli added the id:23H1 Implementer's draft for 2023 H1 label Mar 22, 2023
@timcappalli timcappalli requested review from FragLegs and tulshi March 22, 2023 20:26
Copy link
Contributor

@FragLegs FragLegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should be clear about the expected behavior and that only allowing one stream per receiver is the uncommon case.

@timcappalli timcappalli requested a review from FragLegs June 13, 2023 17:51
@timcappalli timcappalli requested a review from FragLegs August 1, 2023 18:26
Added error description in the table
@independentid
Copy link

409 may not be appropriate. If you look at the definition the problem is that the client should try again...

https://datatracker.ietf.org/doc/html/rfc7231#section-6.5.9

403 seems appropriate because it says retrying won't fix the issue.

@timcappalli
Copy link
Member Author

timcappalli commented Aug 2, 2023

403 seems appropriate because it says retrying won't fix the issue.

We spent almost an hour debating this one yesterday. I don't think 403 is appropriate either as it talks about authorization.

https://datatracker.ietf.org/doc/html/rfc7231#section-6.5.9 > "...but refuses to authorize it."

We landed on 409 because the receiver can ultimately resolve this by changing their request.

@independentid
Copy link

independentid commented Aug 2, 2023 via email

@independentid
Copy link

independentid commented Aug 2, 2023 via email

Copy link
Contributor

@FragLegs FragLegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tulshi tulshi merged commit a2fe379 into main Sep 22, 2023
@tulshi tulshi deleted the tc-46-streamexists branch September 22, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

id:23H1 Implementer's draft for 2023 H1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants