Poll transmitter specified url #69
Conversation
FragLegs
left a comment
FragLegs
left a comment
There was a problem hiding this comment.
I think you originally intended for this to be a documentation-only change. It might be easier if that's all it was and we left the renaming of method and endpoint_url for a different pull request.
| { | ||
| "delivery": { | ||
| "delivery_method": "urn:ietf:rfc:8935", | ||
| "method": "urn:ietf:rfc:8935", |
There was a problem hiding this comment.
I looked at the already approved spec and it appears that the spec uses delivery_method key.
"delivery": {
"delivery_method":
"https://schemas.openid.net/secevent/risc/delivery-method/push",
"url": "https://receiver.example.com/events"
},
https://openid.net/specs/openid-sse-framework-1_0-ID1.html#rfc.section.7.1.2.2
Though I would have liked the method over delivery_method (as described earlier), that would break the backwards compatibility of transmitter's APIs.
There was a problem hiding this comment.
The currently approved spec uses method in the spec (see sections 11.2.1.1. and 11.2.1.2), and mistakenly uses delivery_method in the examples.
There was a problem hiding this comment.
Thank you for clarifying it :)
There was a problem hiding this comment.
@FragLegs @tulshi noticed discrepancy around endpoint_url vs url. The spec mentions endpoint_url (see sections 11.2.1.1. and 11.2.1.2)
And examples show url. Could we align on this either in this PR or a brand new?
Closes #36 (previous commits incorrectly refer to #45)