Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new sub_id related language. Modified existing language to refl… #82

Merged
merged 15 commits into from
Sep 26, 2023

Conversation

tulshi
Copy link
Contributor

@tulshi tulshi commented Jul 17, 2023

…ect the use of the sub_id claim

@independentid
Copy link

The format value is an IANA registered format to avoid conflicts. The term "complex" is probably too generic.

You may want to prefix it with the spec name (e.g. caep, risc, ssf) For example "caep_complex".

Registration info is in section 8.1 of the subject identifier draft.

Other than that looks good.

openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
@FragLegs
Copy link
Contributor

The format value is an IANA registered format to avoid conflicts. The term "complex" is probably too generic.

You may want to prefix it with the spec name (e.g. caep, risc, ssf) For example "caep_complex".

Registration info is in section 8.1 of the subject identifier draft.

@independentid Can we separate that into another issue/pull request to avoid polluting the discussion of this one?

@independentid
Copy link

Sure. Could be handled as a separate issue.

openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Show resolved Hide resolved
Copy link
Contributor

@appsdesh appsdesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add following in the section Distinguishing SETs from other Kinds of JWTs

The "sub_id" claim MUST be present, as described in {{{subject-members}}

Copy link
Contributor

@appsdesh appsdesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! Thanks

openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
openid-sharedsignals-framework-1_0.md Outdated Show resolved Hide resolved
@tulshi tulshi merged commit 6ed4115 into main Sep 26, 2023
2 checks passed
@tulshi tulshi deleted the sub_id-changes branch September 26, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should subject identifier be pulled out of the event definitions?
5 participants