Skip to content

Conversation

@FragLegs
Copy link
Contributor

@FragLegs FragLegs commented Jul 25, 2023

This PR deals with two different uses of format

  1. It removes format from the stream configuration. Here, format means that the stream should expect to only deal with subjects using this format identifier. This closes issue We should include "format" in at least one of the stream configuration examples #54
  2. It adds format to the CAEP event normative examples. Here, format is used to denote that the subject in the event is a complex subject. We didn't update this file when we created PR Added format field to complex subjects and updated examples #71

@FragLegs FragLegs requested review from timcappalli and tulshi July 25, 2023 18:58
@independentid
Copy link

independentid commented Jul 28, 2023 via email

@timcappalli
Copy link
Member

@FragLegs if we're saying that sub_id needs to be used, should we refactor all of the examples to use sub_id?

@FragLegs
Copy link
Contributor Author

@FragLegs if we're saying that sub_id needs to be used, should we refactor all of the examples to use sub_id?

I think that work is being done in #82 right?

@tulshi tulshi requested a review from appsdesh September 5, 2023 16:40
Copy link
Member

@timcappalli timcappalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@FragLegs FragLegs merged commit 4e1f42e into main Sep 11, 2023
@FragLegs FragLegs deleted the add-format branch September 11, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants