-
Notifications
You must be signed in to change notification settings - Fork 19
Add 'format' to stream config and normative examples in CAEP #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th different meanings)
appsdesh
requested changes
Jul 25, 2023
|
I think there is a general issue of concern that needs more discussion. AFAIK the format is a configuration issue for streams that says what identifier formats and attributes will be used to identify subjects in feeds. SCIM has some variability especially considering ldap and azure to cloud. I recall google IDP had no clear what to identify subjects as they vary dramatically between RPs. The the important functionality is that is represents how the issuer and audience have agreed to identify subjects. Yes you could force a single value in the standard but that makes the standard fragile because it becomes limited in usability. For scim I had proposed “Id” and “externalId” is this is what the scim protocol standardizes. Many have complained that scim is too limited. Others point out that some receivers will not be scim but other systems like ldap or security AI. Subject ID spec and format became the became the way to move forward. The downside remains how can one build an infinite number of parsers? The trade off being so you build ssf servers one set of specs and cases or do you add extensibility to handle new format cases over time. After all this is what consultants and integrators do. PhilOn Jul 28, 2023, at 9:47 AM, Apoorva Deshpande ***@***.***> wrote:
@appsdesh commented on this pull request.
In openid-sharedsignals-framework-1_0.md:
@@ -887,7 +887,8 @@ Authorization: Bearer eyJ0b2tlbiI6ImV4YW1wbGUifQo=
"urn:example:secevent:events:type_2",
"urn:example:secevent:events:type_3",
"urn:example:secevent:events:type_4"
- ]
+ ],
+ "format": "email"
Thanks for clarifying things for me @FragLegs!
Just like "subjects" are getting removed from the status, I think it would add the value to fix this abstraction/layering issue before the spec is sent for approval. On that note, it may not be needed to update examples at this point.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Member
|
@FragLegs if we're saying that |
Contributor
Author
tulshi
approved these changes
Sep 5, 2023
appsdesh
approved these changes
Sep 5, 2023
timcappalli
approved these changes
Sep 10, 2023
Member
timcappalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with two different uses of
formatformatfrom the stream configuration. Here,formatmeans that the stream should expect to only deal with subjects using this format identifier. This closes issue We should include "format" in at least one of the stream configuration examples #54formatto the CAEP event normative examples. Here,formatis used to denote that the subject in the event is a complex subject. We didn't update this file when we created PR Added format field to complex subjects and updated examples #71