Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in beatTimecode calculation (org.openimaj.audio.analysis.BeatDetector.process(SampleChunk)) #111

Open
shiregator opened this Issue Oct 11, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@shiregator
Copy link

shiregator commented Oct 11, 2016

Hi,

The beatTimecode calculation is incorrect:
this.beatTimecode.setTimecodeInMilliseconds( (long)(
samples.getStartTimecode().getTimecodeInMilliseconds() +
i * this.format.getSampleRateKHz() ) );

It should be:
this.beatTimecode.setTimecodeInMilliseconds( (long)(
samples.getStartTimecode().getTimecodeInMilliseconds() +
i / this.format.getSampleRateKHz() ) );

Thanks!
Jamie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.