Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPL-88: moved valuation into fee-for-service #24

Merged
merged 14 commits into from May 8, 2022
Merged

Conversation

sniedzielski
Copy link
Contributor

@sniedzielski sniedzielski commented Apr 5, 2022

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2022

This pull request fixes 2 alerts when merging 5b63632 into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2022

This pull request fixes 2 alerts when merging f575b63 into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

Copy link
Member

@delcroip delcroip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the move to payment plan params add more changes

claim_batch/services.py Outdated Show resolved Hide resolved
claim_batch/services.py Outdated Show resolved Hide resolved
claim_batch/services.py Show resolved Hide resolved
claim_batch/services.py Show resolved Hide resolved
claim_batch/services.py Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Apr 5, 2022

This pull request fixes 2 alerts when merging a6dcaaa into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2022

This pull request fixes 2 alerts when merging a51a55a into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 6, 2022

This pull request fixes 2 alerts when merging f4fa9ce into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 21, 2022

This pull request fixes 2 alerts when merging 8398d3f into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 2 alerts when merging 9f2c635 into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 2 alerts when merging fa05445 into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 2 alerts when merging 67a969f into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented Apr 22, 2022

This pull request fixes 2 alerts when merging 343035d into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

@lgtm-com
Copy link

lgtm-com bot commented May 6, 2022

This pull request fixes 2 alerts when merging a3d8037 into c802431 - view on LGTM.com

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

- provide a function to update claims
- fix the start date function
- fix allocated amount
- call directly calcrule calculate is using signals
@delcroip delcroip merged commit 02273a4 into develop May 8, 2022
@delcroip delcroip deleted the feature/OPL-88 branch May 8, 2022 11:51
@lgtm-com
Copy link

lgtm-com bot commented May 8, 2022

This pull request introduces 4 alerts and fixes 2 when merging c1d46ca into c802431 - view on LGTM.com

new alerts:

  • 4 for Unused import

fixed alerts:

  • 1 for Unused local variable
  • 1 for Suspicious unused loop iteration variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants