Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/omt 190 no tech user autoprovision #12

Merged
merged 2 commits into from May 29, 2020
Merged

Hotfix/omt 190 no tech user autoprovision #12

merged 2 commits into from May 29, 2020

Conversation

xgill
Copy link
Contributor

@xgill xgill commented May 28, 2020

Only auto-provision 'interactive' users (i.e. users registered in tblUsers)

@xgill xgill requested a review from edarchis May 28, 2020 12:17
@xgill xgill changed the base branch from develop to OMT-204_components_upgrade May 28, 2020 12:18
@lgtm-com
Copy link

lgtm-com bot commented May 28, 2020

This pull request introduces 1 alert and fixes 14 when merging ac71483 into 2ae888f - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 6 for Unused import
  • 3 for 'import *' may pollute namespace
  • 2 for First parameter of a method is not named 'self'
  • 2 for Except block handles 'BaseException'
  • 1 for Module is imported with 'import' and 'import from'

@edarchis edarchis merged commit 67d6332 into OMT-204_components_upgrade May 29, 2020
@edarchis edarchis deleted the hotfix/OMT-190-no_tech_user_autoprovision branch May 29, 2020 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edarchis edarchis edarchis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xgill @edarchis