Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove localhost from metadata $id #629

Closed
philecs opened this issue Aug 2, 2019 · 0 comments

Comments

@philecs
Copy link
Contributor

commented Aug 2, 2019

When getting a schema the $id contains the domain, e.g:

"$id": "http://localhost:3000/api/v1/domains/5d43e4db21a4cd00112bfd91/schemas/philTest1",

Further description:

Should $id contain complete uri or only philTest1?^

Example object:

{
    "data": {
        "id": "5d43e53821a4cd00112bfd92",
        "refs": [],
        "name": "My first test domain",
        "domainId": "5d43e4db21a4cd00112bfd91",
        "description": "Test to add domain",
        "uri": "/api/v1/domains/5d43e4db21a4cd00112bfd91/schemas/philTest1",
        "value": {
            "$id": "http://localhost:3000/api/v1/domains/5d43e4db21a4cd00112bfd91/schemas/philTest1",
            "required": [
                "name",
                "age"
            ],
            "properties": {
                "name": {
                    "type": "string"
                },
                "age": {
                    "type": "number"
                },
                "gender": {
                    "type": "string"
                }
            }
        },
        "owners": [
            {
                "id": "5cdd366361c5f3001061b017",
                "type": "USER"
            },
            {}
        ],
        "createdAt": "2019-08-02T07:24:40.592Z",
        "updatedAt": "2019-08-02T07:24:40.592Z"
    }
}

Acceptance Criteria:

  • $id doesn't contain localhost anymore

Definition of Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.