New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise and restructure for the new web-page generator #10
Conversation
- Raise `<h4>`s to `<h3>`s (`s/^#### /### /`) - Add `{.author}` to `<h4>`s listing authors and dates - Use `<br>` in multi-line author blocks - Adjust emphasis in a few places, using blockquotes and italics - Use `## Sub title {.subtitle}` for subtitles - Use unordered lists where appropriate
This change restores the JavaScript-driven highlighting of control characters in this guide. It also replaces the control characters that do not exist in the Deja Vu fonts, namely - 2409 SYMBOL FOR HORIZONTAL TABULATION (␉) - 240D SYMBOL FOR CARRIAGE RETURN (␍) - 240A SYMBOL FOR LINE FEED (␊) with corresponding arrow symbols that do exist in those fonts: - 21A6 RIGHTWARDS ARROW FROM BAR (↦) - 2190 LEFTWARDS ARROW (←) - 2193 DOWNWARDS ARROW (↓)
👋 Welcome back mr! A progress list of the required criteria for merging this PR into |
Skara doesn’t (yet) like symbolic links.
@mbreinhold This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Please review these changes to revise and restructure the amber-docs repository for use with the new web-page generator for
openjdk.java.net
.That generator is presently defined in https://github.com/mbreinhold/ojweb-generate, which will shortly be moved over to the OpenJDK organization. Please see the
README.md
file in that repository for instructions on how to use it.I’ve tried to keep content changes to a minimum, primarily adjusting minor things such as heading levels and code examples for better rendering.
You can preview the output here: https://openjdk.java.net/_test/amber/
For easy reviewing, there’s also a map of the entire subtree: https://openjdk.java.net/_test/amber/_map
Progress
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/amber-docs pull/10/head:pull/10
$ git checkout pull/10
Update a local copy of the PR:
$ git checkout pull/10
$ git pull https://git.openjdk.java.net/amber-docs pull/10/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10
View PR using the GUI difftool:
$ git pr show -t 10
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/amber-docs/pull/10.diff