Skip to content

Conversation

@sormuras
Copy link
Member

@sormuras sormuras commented Sep 25, 2024

Please review this follow-up change to use the correct directory name for workflows.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/apidiff.git pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/11.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2024

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903836: apidiff: Add GitHub Actions test workflow

Reviewed-by: jjg

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2024
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2024

Going to push as commit a10e142.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2024
@openjdk openjdk bot closed this Sep 25, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2024
@openjdk
Copy link

openjdk bot commented Sep 25, 2024

@sormuras Pushed as commit a10e142.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the fix-github-actions-directory-name branch September 25, 2024 16:42
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants