7903837: apidiff: build.sh issues on Windows

[jonathan-gibbons]

Please review some build.sh and Makefile changes to address issues building on Windows.

The primary Windows issue was missing use of mixed_path when passing some filenames into make.
There is some additional cleanup (for all platforms) to normalize the DEPS_DIR and add missing items to the sanity and check_build_vars targets.

This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• CODETOOLS-7903837: apidiff: build.sh issues on Windows (Bug - P3)

Reviewers

• Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/12/head:pull/12
$ git checkout pull/12

Update a local copy of the PR:
$ git checkout pull/12
$ git pull https://git.openjdk.org/apidiff.git pull/12/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 12

View PR using the GUI difftool:
$ git pr show -t 12

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/12.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jjg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jonathan-gibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

7903837: apidiff: build.sh issues on Windows

Reviewed-by: iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 10a494c: 7903830: apidiff: Review glyphs used to indicate same/difference
• e0b049a: 7903849: Scrape off Apache Ant remnants from APIDiff
• dbaa7ac: 7903846: apidiff: test issues on Windows
• bb3eb15: 7903838: apidiff: Update Vintage JUnit test
• c432f4a: 7903841: apidiff: IllegalStateException for RECORD in TypePageReporter
• a7e2218: 7903835: apidiff: CompareOptionsTest fails on recent JDK
• 95b7345: 7903834: apidiff: DocPath issue on Windows
• a10e142: 7903836: apidiff: Add GitHub Actions test workflow
• a1bacee: 7903836: apidiff: Add GitHub Actions test workflow
• b8685ae: 7903829: apidiff: update TestNG reference to JUnit
• ... and 3 more: https://git.openjdk.org/apidiff/compare/f73e256ef56462b6c23748736fc012a4015fee31...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 03: Full - Incremental (6d3c8943)
• 02: Full - Incremental (afc38f77)
• 01: Full - Incremental (25765982)
• 00: Full (61a3c05c)

[sormuras]

This has been tested on macOS. Can someone with access to a Windows machine test it on Windows, please?

On it. An empty classpath element results in a :: sequence, which seems to make MSYS2/Cygwin fail the build.

[sormuras]

apidiff/test/junit/JUnitTests.gmk

Line 33 in a10e142

$(BUILDTESTDIR)/JUnitTests/classes:$(APIDIFF_IMAGEDIR)/lib/apidiff.jar:$(JAVADIFFUTILS_JAR):$(DAISYDIFF_JAR):$(HTMLCLEANER_JAR)

also needs some extra care to not pass an empty $(DAISYDIFF_JAR) element.

[jonathan-gibbons]

/integrate

[openjdk]

Going to push as commit ac5e9e7.
Since your change was applied there have been 15 commits pushed to the master branch:

• 8974473: 7903851: apidiff: typo in comment for HtmlDiffBuilderTest
• 1884101: 7903852: apidiff: IllegalArgumentException for RECORD_COMPONENT
• 10a494c: 7903830: apidiff: Review glyphs used to indicate same/difference
• e0b049a: 7903849: Scrape off Apache Ant remnants from APIDiff
• dbaa7ac: 7903846: apidiff: test issues on Windows
• bb3eb15: 7903838: apidiff: Update Vintage JUnit test
• c432f4a: 7903841: apidiff: IllegalStateException for RECORD in TypePageReporter
• a7e2218: 7903835: apidiff: CompareOptionsTest fails on recent JDK
• 95b7345: 7903834: apidiff: DocPath issue on Windows
• a10e142: 7903836: apidiff: Add GitHub Actions test workflow
• ... and 5 more: https://git.openjdk.org/apidiff/compare/f73e256ef56462b6c23748736fc012a4015fee31...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jonathan-gibbons Pushed as commit ac5e9e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.