-
Notifications
You must be signed in to change notification settings - Fork 9
7903839: apidiff: Add a "make docs" target for the primary internal API #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903839: apidiff: Add a "make docs" target for the primary internal API #14
Conversation
|
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
|
This is a draft request until we can merge with #12 to fix some build issues on Windows. |
|
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 18800d3.
Your commit was automatically rebased without conflicts. |
|
@jonathan-gibbons Pushed as commit 18800d3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a small Makefile update to expose a friendly "make docs" target to generate API documentation for the internal API.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/14/head:pull/14$ git checkout pull/14Update a local copy of the PR:
$ git checkout pull/14$ git pull https://git.openjdk.org/apidiff.git pull/14/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14View PR using the GUI difftool:
$ git pr show -t 14Using diff file
Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/14.diff