-
Notifications
You must be signed in to change notification settings - Fork 9
7903830: apidiff: Review glyphs used to indicate same/difference #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7903830: apidiff: Review glyphs used to indicate same/difference #17
Conversation
|
👋 Welcome back jjg! A progress list of the required criteria for merging this PR into |
|
@jonathan-gibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
|
/integrate |
|
Going to push as commit 10a494c.
Your commit was automatically rebased without conflicts. |
|
@jonathan-gibbons Pushed as commit 10a494c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review a medium small fix to change the glyphs used to visually indicate whether elements are the same, different, or in the case of a two-way comparison, added or removed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/apidiff.git pull/17/head:pull/17$ git checkout pull/17Update a local copy of the PR:
$ git checkout pull/17$ git pull https://git.openjdk.org/apidiff.git pull/17/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 17View PR using the GUI difftool:
$ git pr show -t 17Using diff file
Download this PR as a diff file:
https://git.openjdk.org/apidiff/pull/17.diff
Webrev
Link to Webrev Comment