Skip to content

7903830: apidiff: Review glyphs used to indicate same/difference #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

7903830: apidiff: Review glyphs used to indicate same/difference #17

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8fa4a2
CODETOOLS-7903830: apidiff: Review glyphs used to indicate same/diffe…
jonathan-gibbons Sep 27, 2024
5e3bf9e
Add TODO comment in Main
jonathan-gibbons Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/share/classes/jdk/codetools/apidiff/Main.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,8 @@ private Result run(List<String> args, Log log) {
Selector s = new Selector(options.includes, options.excludes);
AccessKind ak = options.getAccessKind();

// TODO: when APIDiff moves to JDK 21, thia can trivially become SequencedSet,
// which would be useful in varoius places, such as PageReporter.getResultGlyph
Set<API> apis = options.allAPIOptions.values().stream()
.map(a -> API.of(a, s, ak, log))
.collect(Collectors.toCollection(LinkedHashSet::new));
Expand Down